docs(performance): Add performance config documentation #500
Conversation
| - thelarkinn | ||
| --- | ||
|
|
||
| The options allows you to control how webpack notifies you of assets and entrypoints that exceed a specific file limit. |
| } | ||
| ``` | ||
|
|
||
| A warning will be displayed notifying you of a large asset. We recommend something like this for development environments. |
There was a problem hiding this comment.
Let's say you are inlining assets during development, missing minification etc., wouldn't this yield warnings even if they aren't relevant? Isn't the best value in production build?
There was a problem hiding this comment.
Yes, but also gives perspective to users as they are developing.
If a bundle grows from 200->350kb after a certain feature, I'd want to know specifically about it while developing so I can trace my steps back a few changes and investigate more into what is causing the bloat.
There was a problem hiding this comment.
Alright. I guess it takes more experience with the feature for me to tell any better. Hitting the limits is very easy by inlining just a few images.
There was a problem hiding this comment.
Developing the last thing I'd like is to be caught of guard after x hours of development to see errors because of size stuff I could maybe have caught in the act.
Again these are just hypothetical/estimates etc.
There was a problem hiding this comment.
Yes true. Maybe that's where they could filter assets, etc.
I mean at the most these are recommendations but I 100% agree where you are coming from.
There was a problem hiding this comment.
Would it make sense to have something like --json kind of flag for the perf data? Can you get it in JSON to track?
There was a problem hiding this comment.
Aww that would actually be a really cool feature but the log might be built. I'm going to add that to the original issue.
|
Any other looks? Want to get this in since Perf is in now. |
|
Any other objections? Going to merge this. |
|
Yeah, merge. More tweaks can be done in separate PRs. |
Fixes #435